feat: memory record batch reader #157
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shaoting-huang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
shaoting-huang
force-pushed
the
partial_read
branch
from
0485e2a to
136fe37
Compare
tedxu
reviewed
Dec 27, 2024
| const std::string& path, | ||
| const std::shared_ptr<arrow::Schema> schema, | ||
| const size_t start_row_group, | ||
| const size_t end_row_group, |
There was a problem hiding this comment.
It is not easy to know if the end_row_group is inclusive or not.
tedxu
reviewed
Dec 27, 2024
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
force-pushed
the
partial_read
branch
from
0ac6c8b to
5a106dc
Compare
Signed-off-by: shaoting-huang <[email protected]>
Signed-off-by: shaoting-huang <[email protected]>
shaoting-huang
changed the title
Signed-off-by: shaoting-huang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related: #158